Proper names for dataset types #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1625
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8e2e564 with merge base 63208c6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
ebsmothers
reviewed
Sep 19, 2024
| @@ -9,7 +9,7 @@ torchtune.datasets | |||
| For a detailed general usage guide, please see our :ref:`datasets tutorial <dataset_tutorial_label>`. | |||
|
|
|||
|
|
|||
| Text-only datasets | |||
| Text datasets | |||
| ------------------ | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1625 +/- ##
==========================================
- Coverage 72.26% 70.45% -1.81%
==========================================
Files 290 291 +1
Lines 14554 14644 +90
==========================================
- Hits 10517 10318 -199
- Misses 4037 4326 +289 ☔ View full report in Codecov by Sentry. |
RdoubleA
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Changes names to match more closely how datasets are represented on the HuggingFace Hub. Easier to find.
Changelog
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install)pytest testspytest tests -m integration_testUX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example